Fix S3655 FP: HasValue checked with Pattern matching

[pavel-mikula-sonarsource]

Reported here: https://community.sonarsource.com/t/rule-c-s3655-false-positive-for-pattern/81703

public struct Repro_6682
{
    public bool SomeProperty { get; }

    public void PatternMatching(Repro_6682? arg, bool condition)
    {
        if (condition)
        {
            arg = null;
        }

        if (arg is { SomeProperty: true })   // A null check
        {
            var value = arg.Value;  // Noncompliant FP
        }

        if (arg is { })   // A null check
        {
            var value = arg.Value;  // Noncompliant FP
        }
    }
}

[Gakk]

Thanks for confirming this issue @pavel-mikula-sonarsource 👍

You gave a timeframe for Q1 on the community:

We plan to rework this rule in Q1 and that should also fix this issue.

Currently our developers get failed on the quality gate:

Is there any way to modify this rule using SonarCloud, without lowering the quality gate for all rules?

[pavel-mikula-sonarsource]

You should mark it as False Positive in SonarCloud UI

[Gakk]

You should mark it as False Positive in SonarCloud UI

I thought marking in SonarCloud UI also involved manually overriding check on GitHub pull request (or re-run analyze), but your integration updated both comment and check immediately! Kudos! 🥳🚀

[martin-strecker-sonarsource]

Fixed as part of sprint 8.56