Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S3253 FN: primary parameterless constructors #8092

Closed
antonioaversa opened this issue Sep 27, 2023 · 0 comments · Fixed by #8227
Closed

Fix S3253 FN: primary parameterless constructors #8092

antonioaversa opened this issue Sep 27, 2023 · 0 comments · Fixed by #8227
Assignees
Labels
Area: C#12 C#12 related issues Type: False Negative Rule is NOT triggered when it should be.
Projects
Milestone

Comments

@antonioaversa
Copy link
Contributor

antonioaversa commented Sep 27, 2023

Primary parameterless constructors are redundant as parameterless constructors and should be reported by S3253.

class AClassWithBody() { }                // FN
class AClassWithoutBody();                // FN
struct AStructWithBody() { }              // FN
struct AStructWithoutBody();              // FN
record ARecordWithBody() { }              // FN
record ARecordWithoutBody();              // FN
record struct ARecordStructWithBody() { } // FN
record struct ARecordStructWithoutBody(); // FN

Alternative: extend S3235 instead.

@antonioaversa antonioaversa added Type: False Negative Rule is NOT triggered when it should be. Area: C#12 C#12 related issues labels Sep 27, 2023
antonioaversa added a commit that referenced this issue Sep 27, 2023
antonioaversa added a commit that referenced this issue Sep 28, 2023
antonioaversa added a commit that referenced this issue Sep 28, 2023
antonioaversa added a commit that referenced this issue Sep 29, 2023
@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource moved this from To do to In progress in Best Kanban Oct 18, 2023
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban Oct 18, 2023
@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource moved this from Review in progress to In progress in Best Kanban Oct 19, 2023
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban Oct 19, 2023
@sebastien-marichal sebastien-marichal removed their assignment Oct 19, 2023
@github-actions github-actions bot moved this from Review in progress to In progress in Best Kanban Oct 20, 2023
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban Oct 20, 2023
@github-actions github-actions bot moved this from Review in progress to Review approved in Best Kanban Oct 20, 2023
@antonioaversa antonioaversa moved this from Review approved to In progress in Best Kanban Oct 20, 2023
@antonioaversa antonioaversa moved this from In progress to Review approved in Best Kanban Oct 20, 2023
@antonioaversa antonioaversa moved this from Review approved to In progress in Best Kanban Oct 20, 2023
@github-actions github-actions bot moved this from In progress to Review approved in Best Kanban Oct 23, 2023
@antonioaversa antonioaversa moved this from Review approved to In progress in Best Kanban Oct 23, 2023
@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource moved this from In progress to Review approved in Best Kanban Oct 23, 2023
Best Kanban automation moved this from Review approved to Validate Peach Oct 23, 2023
@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource moved this from Validate Peach to Done in Best Kanban Oct 25, 2023
@andrei-epure-sonarsource andrei-epure-sonarsource added this to the 9.13 milestone Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: C#12 C#12 related issues Type: False Negative Rule is NOT triggered when it should be.
Projects
Best Kanban
  
Done
Development

Successfully merging a pull request may close this issue.

4 participants