Fix S3358 FP: Nested ternary operator is in a lambda

[martin-strecker-sonarsource]

Fixes #5773

Todo

• VB Support?

[Corniel]

As mentioned at the Community Platform, I think this is not a false positive; it's about readability, and that does not change by having lamda's or not.

[martin-strecker-sonarsource]

The ITs found the following FPs

// 1.
                var configWithDefaultFallback = bootstrap.HasValue
                    ? bootstrap.Value.Config.Select(c => c == _defaultConfig ? c : c.WithFallback(_defaultConfig))
                    : _defaultConfig;
// 2.
            var messages = (SupportsAtomicPersistAllOfSeveralEvents
                ? Enumerable.Range(from, to - 1)
                    .Select(
                        i =>
                            i == to - 1
                                ? new AtomicWrite(
                                    new[] {persistent(i), persistent(i + 1)}.ToImmutableList<IPersistentRepresentation>())
                                : new AtomicWrite(persistent(i)))
                : Enumerable.Range(from, to).Select(i => new AtomicWrite(persistent(i))))
                .ToArray();

// 3.
            return empty != null
                ? new object[0]
                : ctors.First().GetParameters().Select(p => p.ParameterType.IsValueType ? Activator.CreateInstance(p.ParameterType) : null).ToArray();

[pavel-mikula-sonarsource]

LGTM

[pavel-mikula-sonarsource]

Nice

[pavel-mikula-sonarsource]

Let's add noncompliant

var lambda3 = new Func<string, string>(s => isMale ? "Mr. " : isMarried ? "Mrs. " : "Miss ")

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

[martin-strecker-sonarsource]

Validation errors:

• https://peach.sonarsource.com/project/issues?id=aspnetcore&issues=AXoJkZ-rXaALAbC4waMZ&open=AXoJkZ-rXaALAbC4waMZ

[martin-strecker-sonarsource]

@andrei-epure-sonarsource I checked this on peach and found one nonreproducible issue (see above). Can we have a look together?