CSharpObjectInitializationTracker: Add support for tuples and assignment and declaration in the same deconstruction part 2 #5841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-strecker-sonarsource
approved these changes
Jul 14, 2022
| { | ||
| var assignmentMap = assignment.MapAssignmentArguments(); | ||
| return assignmentMap.Any(x => variableSymbol.Equals(GetAssignedVariableSymbol(x.Left, semanticModel)) | ||
| && IsTrackedPropertyName(x.Left) |
There was a problem hiding this comment.
IsTrackedPropertyName should go first, because it is not querying the semantic model.
github-actions
bot
assigned csaba-sagi-sonarsource and unassigned martin-strecker-sonarsource
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
csaba-sagi-sonarsource
deleted the
čaba/csharpObjectInitializationTracker-decon
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.