S2068: Support colon in uri password #6199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
assigned martin-strecker-sonarsource and unassigned pavel-mikula-sonarsource
martin-strecker-sonarsource
approved these changes
Oct 12, 2022
Comment on lines
83
to
91
| var loginGroup = CreateUserInfoGroup("Login", null); | ||
| var passwordGroup = CreateUserInfoGroup("Password", ":"); // Additional ":" to capture passwords containing it | ||
| uriUserInfoPattern = new Regex(@$"\w+:\/\/{loginGroup}:{passwordGroup}@", RegexOptions.Compiled); | ||
| this.configuration = configuration; | ||
| rule = Language.CreateDescriptor(DiagnosticId, MessageFormat); | ||
| CredentialWords = DefaultCredentialWords; // Property will initialize multiple state variables | ||
|
|
||
| static string CreateUserInfoGroup(string name, string additionalCharacterss) => | ||
| $@"(?<{name}>[\w\d{Regex.Escape(UriPasswordSpecialCharacters)}{additionalCharacterss}]+)"; |
There was a problem hiding this comment.
Typo and small improvement
Suggested change
| var loginGroup = CreateUserInfoGroup("Login", null); | |
| var passwordGroup = CreateUserInfoGroup("Password", ":"); // Additional ":" to capture passwords containing it | |
| uriUserInfoPattern = new Regex(@$"\w+:\/\/{loginGroup}:{passwordGroup}@", RegexOptions.Compiled); | |
| this.configuration = configuration; | |
| rule = Language.CreateDescriptor(DiagnosticId, MessageFormat); | |
| CredentialWords = DefaultCredentialWords; // Property will initialize multiple state variables | |
| static string CreateUserInfoGroup(string name, string additionalCharacterss) => | |
| $@"(?<{name}>[\w\d{Regex.Escape(UriPasswordSpecialCharacters)}{additionalCharacterss}]+)"; | |
| var loginGroup = CreateUserInfoGroup("Login"); | |
| var passwordGroup = CreateUserInfoGroup("Password", ":"); // Additional ":" to capture passwords containing it | |
| uriUserInfoPattern = new Regex(@$"\w+:\/\/{loginGroup}:{passwordGroup}@", RegexOptions.Compiled); | |
| this.configuration = configuration; | |
| rule = Language.CreateDescriptor(DiagnosticId, MessageFormat); | |
| CredentialWords = DefaultCredentialWords; // Property will initialize multiple state variables | |
| static string CreateUserInfoGroup(string name, string additionalCharacters = null) => | |
| $@"(?<{name}>[\w\d{Regex.Escape(UriPasswordSpecialCharacters)}{additionalCharacters}]+)"; |
github-actions
bot
assigned pavel-mikula-sonarsource and unassigned martin-strecker-sonarsource
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rfc-editor.org/rfc/rfc3986#section-3.2.1 defines userInfo as
therefore
:is valid part of the password