Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S3875 FP: Do not raise an issue when implementing IEqualityOperators interface #6316

Merged
merged 4 commits into from
Nov 14, 2022
Merged

Fix S3875 FP: Do not raise an issue when implementing IEqualityOperators interface #6316

merged 4 commits into from
Nov 14, 2022

Conversation

gregory-paidis-sonarsource
Copy link
Contributor

Fixes #6312

cristian-ambrosini-sonarsource
cristian-ambrosini-sonarsource approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

analyzers/src/SonarAnalyzer.CSharp/Rules/DotNotOverloadOperatorEqual.cs Outdated Show resolved Hide resolved
@gregory-paidis-sonarsource gregory-paidis-sonarsource changed the title Fix a FP for S3875 (DotNotOverloadOperatorEqual) Fix S3875 FP: Do not raise an issue when implementing IEqualityOperators interface Nov 8, 2022
csaba-sagi-sonarsource
csaba-sagi-sonarsource suggested changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@csaba-sagi-sonarsource csaba-sagi-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I have left a few minor comments.

@sonarcloud
Copy link

sonarcloud bot commented Nov 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Nov 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

csaba-sagi-sonarsource
csaba-sagi-sonarsource approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@csaba-sagi-sonarsource csaba-sagi-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@csaba-sagi-sonarsource csaba-sagi-sonarsource merged commit e84fc45 into master Nov 14, 2022
@csaba-sagi-sonarsource csaba-sagi-sonarsource deleted the greg/S3875-FP-fix branch November 14, 2022 16:55
@csaba-sagi-sonarsource csaba-sagi-sonarsource removed their assignment Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csaba-sagi-sonarsource csaba-sagi-sonarsource csaba-sagi-sonarsource approved these changes

@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource approved these changes

Assignees

@gregory-paidis-sonarsource gregory-paidis-sonarsource

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix S3875 FP: Do not raise an issue when implementing IEqualityOperators interface
3 participants
@gregory-paidis-sonarsource @csaba-sagi-sonarsource @cristian-ambrosini-sonarsource