Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S3267 FN: Support list pattern #6414

Merged
merged 9 commits into from
Dec 6, 2022
Merged

Fix S3267 FN: Support list pattern #6414

merged 9 commits into from
Dec 6, 2022

Conversation

gregory-paidis-sonarsource
Copy link
Contributor

Fixes #6387

cristian-ambrosini-sonarsource
cristian-ambrosini-sonarsource suggested changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just left a few comments for minor stuff

analyzers/src/SonarAnalyzer.CSharp/Rules/LoopsAndLinq.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/LoopsAndLinq.cs Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/LoopsAndLinq.CSharp11.cs Outdated Show resolved Hide resolved
cristian-ambrosini-sonarsource
cristian-ambrosini-sonarsource suggested changes Nov 25, 2022
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last indentation comment

analyzers/src/SonarAnalyzer.CSharp/Rules/LoopsAndLinq.cs Outdated Show resolved Hide resolved
gregory-paidis-sonarsource
gregory-paidis-sonarsource commented Nov 25, 2022
View reviewed changes
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/LoopsAndLinq.CSharp11.cs
foreach (var array in list) // Compliant, do not raise on var pattern in ListPattern
{
if (array is [1, var x, var z])
{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following up on the previous comment, if someone re-wrote this as a Linq Where, the x and y variables would not be properly scoped inside the if statement. Same with is ... local

cristian-ambrosini-sonarsource
cristian-ambrosini-sonarsource approved these changes Nov 25, 2022
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

csaba-sagi-sonarsource
csaba-sagi-sonarsource suggested changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@csaba-sagi-sonarsource csaba-sagi-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Only a bit more left and it can be merged.

csaba-sagi-sonarsource
csaba-sagi-sonarsource suggested changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@csaba-sagi-sonarsource csaba-sagi-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last round of comments.

csaba-sagi-sonarsource
csaba-sagi-sonarsource suggested changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@csaba-sagi-sonarsource csaba-sagi-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last change requested, promise :)

@sonarcloud
Copy link

sonarcloud bot commented Dec 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Dec 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

csaba-sagi-sonarsource
csaba-sagi-sonarsource approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@csaba-sagi-sonarsource csaba-sagi-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@csaba-sagi-sonarsource csaba-sagi-sonarsource marked this pull request as draft December 2, 2022 15:41
@csaba-sagi-sonarsource csaba-sagi-sonarsource marked this pull request as ready for review December 6, 2022 09:30
@csaba-sagi-sonarsource csaba-sagi-sonarsource merged commit fb23659 into master Dec 6, 2022
@csaba-sagi-sonarsource csaba-sagi-sonarsource deleted the greg/fix-S3267-FN branch December 6, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csaba-sagi-sonarsource csaba-sagi-sonarsource csaba-sagi-sonarsource approved these changes

@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource approved these changes

Assignees

@csaba-sagi-sonarsource csaba-sagi-sonarsource

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix S3267 FN: Support list pattern
3 participants
@gregory-paidis-sonarsource @csaba-sagi-sonarsource @cristian-ambrosini-sonarsource