-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor SonarAnalysisContext - Rename SyntaxTreeExtensionsTest #6639
Merged
pavel-mikula-sonarsource
merged 2 commits into
feature/AnalysisContextRefactoring
from
Pavel/Refactor/27-Cleanup
Jan 17, 2023
Merged
Refactor SonarAnalysisContext - Rename SyntaxTreeExtensionsTest #6639
pavel-mikula-sonarsource
merged 2 commits into
feature/AnalysisContextRefactoring
from
Pavel/Refactor/27-Cleanup
Jan 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavel-mikula-sonarsource
force-pushed
the
Pavel/Refactor/26-Parametrized
branch
from
January 16, 2023 14:53
5a9fe0c
to
5530e87
Compare
pavel-mikula-sonarsource
force-pushed
the
Pavel/Refactor/27-Cleanup
branch
from
January 16, 2023 14:54
886b8aa
to
f6e60e9
Compare
github-actions
bot
assigned costin-zaharia-sonarsource and unassigned pavel-mikula-sonarsource
Jan 16, 2023
costin-zaharia-sonarsource
approved these changes
Jan 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
analyzers/tests/SonarAnalyzer.UnitTest/Extensions/SyntaxTreeExtensionsTest.cs
Outdated
Show resolved
Hide resolved
github-actions
bot
assigned pavel-mikula-sonarsource and unassigned costin-zaharia-sonarsource
Jan 17, 2023
pavel-mikula-sonarsource
force-pushed
the
Pavel/Refactor/26-Parametrized
branch
from
January 17, 2023 12:54
5530e87
to
a589525
Compare
pavel-mikula-sonarsource
force-pushed
the
Pavel/Refactor/27-Cleanup
branch
from
January 17, 2023 12:55
1d88fa8
to
36cff32
Compare
Base automatically changed from
Pavel/Refactor/26-Parametrized
to
feature/AnalysisContextRefactoring
January 17, 2023 13:40
pavel-mikula-sonarsource
force-pushed
the
Pavel/Refactor/27-Cleanup
branch
from
January 17, 2023 13:41
36cff32
to
93b738a
Compare
Kudos, SonarCloud Quality Gate passed! |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
pavel-mikula-sonarsource
added a commit
that referenced
this pull request
Jan 17, 2023
pavel-mikula-sonarsource
added a commit
that referenced
this pull request
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6532
File
SyntaxTreeContextExtensionsTest.cs
should not haveContext
in the name and should be inExtensions
directory.