Fix S2094 FP: Allow to have empty class with non-empty ctor for base class #6960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsolt-kolbay-sonarsource
requested changes
Mar 30, 2023
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/ClassShouldNotBeEmpty.CSharp9.cs
Show resolved
Hide resolved
zsolt-kolbay-sonarsource
approved these changes
Apr 6, 2023
Corniel
force-pushed
the
corniel/s2094-fp-records
branch
from
970b2cf
to
93cc46d
Compare
|
@zsolt-kolbay-sonarsource Rebase done. |
|
/azp run Sonar.Net |
|
Azure Pipelines successfully started running 1 pipeline(s). |
andrei-epure-sonarsource
requested changes
Apr 6, 2023
analyzers/src/SonarAnalyzer.CSharp/Rules/ClassShouldNotBeEmpty.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/ClassShouldNotBeEmpty.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/ClassShouldNotBeEmpty.CSharp10.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/ClassShouldNotBeEmpty.CSharp10.cs
Outdated
Show resolved
Hide resolved
|
@andrei-epure-sonarsource Did all of them. |
andrei-epure-sonarsource
approved these changes
Apr 6, 2023
|
/azp run Sonar.Net |
|
Azure Pipelines successfully started running 1 pipeline(s). |
added 4 commits
April 11, 2023 16:53
Corniel
force-pushed
the
corniel/s2094-fp-records
branch
from
91cf77e
to
1edd576
Compare
|
@zsolt-kolbay-sonarsource while reviewing some code with a collegae, I spotted a false negative for this rule: record EmptyChildWithoutBrackets : EmptyRecord; // NoncompliantWhile at it, I extended the rule to also cover this. |
|
/azp run Sonar.Net |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The fix for the FN requires an update of the ITs. Once you've done that I'll merge the PR. |
|
@zsolt-kolbay-sonarsource Can you do that for me please? |
|
/azp run Sonar.Net |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
zsolt-kolbay-sonarsource
merged commit 0d01a33
into
SonarSource:master
22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6953
Also fixes FN for empty record w/o brackets.