Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix syntax error in ObsoleteAttributesNeedExplanation_VB test case #6988

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Fix syntax error in ObsoleteAttributesNeedExplanation_VB test case #6988

merged 1 commit into from
Mar 24, 2023

Conversation

martin-strecker-sonarsource
Copy link
Contributor

No description provided.

@martin-strecker-sonarsource martin-strecker-sonarsource added the Area: VB.NET VB.NET rules related issues. label Mar 24, 2023
@github-actions github-actions bot added this to In progress in Best Kanban Mar 24, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@martin-strecker-sonarsource martin-strecker-sonarsource marked this pull request as ready for review March 24, 2023 11:35
csaba-sagi-sonarsource
csaba-sagi-sonarsource approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@csaba-sagi-sonarsource csaba-sagi-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is the second time in as many weeks that we have the same issue making master red. Can we do something about it, to catch it before merging to master?

@github-actions github-actions bot moved this from In progress to Review approved in Best Kanban Mar 24, 2023
@csaba-sagi-sonarsource csaba-sagi-sonarsource merged commit 69e66ec into master Mar 24, 2023
Best Kanban automation moved this from Review approved to Validate Peach Mar 24, 2023
@csaba-sagi-sonarsource csaba-sagi-sonarsource deleted the Martin/FixMaster branch March 24, 2023 11:39
@Corniel
Copy link
Contributor

Corniel commented Mar 24, 2023

Oops. How did this happen?

@martin-strecker-sonarsource martin-strecker-sonarsource moved this from Validate Peach to Done in Best Kanban Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csaba-sagi-sonarsource csaba-sagi-sonarsource csaba-sagi-sonarsource approved these changes

Assignees

@martin-strecker-sonarsource martin-strecker-sonarsource

Labels
Area: VB.NET VB.NET rules related issues.
Projects
Best Kanban
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@martin-strecker-sonarsource @Corniel @csaba-sagi-sonarsource