SE: Add NumberConstraint #7157
Merged
SE: Add NumberConstraint #7157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavel-mikula-sonarsource
added
the
Sprint: SE
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
Tim-Pohlmann
reviewed
May 2, 2023
analyzers/src/SonarAnalyzer.Common/SymbolicExecution/Constraints/NumberConstraint.cs
Show resolved
Hide resolved
Tim-Pohlmann
approved these changes
May 3, 2023
| } | ||
| } | ||
|
|
||
| public static NumberConstraint From(BigInteger? min, BigInteger? max) |
There was a problem hiding this comment.
Let's rename the parameters (also change them for the private constructor). I think boundary1 and boundary2 are appropriate.
There was a problem hiding this comment.
boundary1 and boundary2 doesn't work for infinite ranges, like > 0 where min=0, max=null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7140