New rule S6605: Collection-specific "Exists" method should be used instead of the "Any" extension #7160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "id": "S6605", | ||
| "message": "Collection-specific "Exists" method should be used instead of the "Any" extension.", | ||
| "location": { | ||
| "uri": "sources\Nancy\src\Nancy.Testing\ConfigurableBootstrapper.cs", |
There was a problem hiding this comment.
| "id": "S6605", | ||
| "message": "Collection-specific "Exists" method should be used instead of the "Any" extension.", | ||
| "location": { | ||
| "uri": "sources\Nancy\src\Nancy.Testing\ConfigurableBootstrapper.cs", |
There was a problem hiding this comment.
| "id": "S6605", | ||
| "message": "Collection-specific "Exists" method should be used instead of the "Any" extension.", | ||
| "location": { | ||
| "uri": "sources\Nancy\src\Nancy.Testing\ConfigurableBootstrapper.cs", |
There was a problem hiding this comment.
| "id": "S6605", | ||
| "message": "Collection-specific "Exists" method should be used instead of the "Any" extension.", | ||
| "location": { | ||
| "uri": "sources\Nancy\src\Nancy.Testing\ConfigurableBootstrapper.cs", |
There was a problem hiding this comment.
| "id": "S6605", | ||
| "message": "Collection-specific "Exists" method should be used instead of the "Any" extension.", | ||
| "location": { | ||
| "uri": "sources\Nancy\src\Nancy.ViewEngines.Spark\NancyViewFolder.cs", |
There was a problem hiding this comment.
| "id": "S6605", | ||
| "message": "Collection-specific "Exists" method should be used instead of the "Any" extension.", | ||
| "location": { | ||
| "uri": "sources\akka.net\src\core\Akka\Actor\ActorProducerPipeline.cs", |
There was a problem hiding this comment.
| "id": "S6605", | ||
| "message": "Collection-specific "Exists" method should be used instead of the "Any" extension.", | ||
| "location": { | ||
| "uri": "sources\akka.net\src\core\Akka\Actor\ActorProducerPipeline.cs", |
There was a problem hiding this comment.
| "id": "S6605", | ||
| "message": "Collection-specific "Exists" method should be used instead of the "Any" extension.", | ||
| "location": { | ||
| "uri": "sources\akka.net\src\core\Akka\Event\EventBus.cs", |
There was a problem hiding this comment.
| "id": "S6605", | ||
| "message": "Collection-specific "Exists" method should be used instead of the "Any" extension.", | ||
| "location": { | ||
| "uri": "sources\akka.net\src\contrib\cluster\Akka.Cluster.Tools\Singleton\OldestChangedBuffer.cs", |
There was a problem hiding this comment.
cristian-ambrosini-sonarsource
force-pushed
the
cristian/S6605
branch
2 times, most recently
from
23dcb49
to
32474cb
Compare
cristian-ambrosini-sonarsource
requested review from
gregory-paidis-sonarsource and
sebastien-marichal
cristian-ambrosini-sonarsource
force-pushed
the
cristian/S6605
branch
from
32474cb
to
bf4c731
Compare
gregory-paidis-sonarsource
requested changes
May 8, 2023
analyzers/tests/SonarAnalyzer.UnitTest/Rules/ExistsInsteadOfAnyTest.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/ExistsInsteadOfAny.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/ExistsInsteadOfAny.vb
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Rules/ExistsInsteadOfAnyBase.cs
Outdated
Show resolved
Hide resolved
cristian-ambrosini-sonarsource
force-pushed
the
cristian/S6605
branch
from
7baef50
to
d6e1da0
Compare
cristian-ambrosini-sonarsource
requested a review
from gregory-paidis-sonarsource
gregory-paidis-sonarsource
requested changes
May 10, 2023
analyzers/src/SonarAnalyzer.Common/Rules/ExistsInsteadOfAnyBase.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.VisualBasic/Rules/ExistsInsteadOfAny.cs
Outdated
Show resolved
Hide resolved
cristian-ambrosini-sonarsource
force-pushed
the
cristian/S6605
branch
from
9d7a862
to
e8c434b
Compare
cristian-ambrosini-sonarsource
requested a review
from gregory-paidis-sonarsource
gregory-paidis-sonarsource
requested changes
May 11, 2023
cristian-ambrosini-sonarsource
requested a review
from gregory-paidis-sonarsource
cristian-ambrosini-sonarsource
force-pushed
the
cristian/S6605
branch
from
d267004
to
fe23c27
Compare
gregory-paidis-sonarsource
requested changes
May 11, 2023
analyzers/src/SonarAnalyzer.VisualBasic/Rules/ExistsInsteadOfAny.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/ExistsInsteadOfAny.cs
Outdated
Show resolved
Hide resolved
cristian-ambrosini-sonarsource
requested a review
from gregory-paidis-sonarsource
cristian-ambrosini-sonarsource
force-pushed
the
cristian/S6605
branch
from
402d777
to
8e0fccc
Compare
|
|
||
| intList.Any(x => x.GetType() == typeof(int)); // Noncompliant | ||
| intList.Any(x => x.GetType().Equals(typeof(int))); // Noncompliant FP | ||
| intList.Any(x => MyIntCheck(x)); // Noncompliant |
There was a problem hiding this comment.
Add this type of check but without the argument for completion sake:
intList.Any(MyIntCheck) // Noncompliantsame for string check
gregory-paidis-sonarsource
approved these changes
May 12, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7123