SE: ComputeBoolConstraint for numeric comparisons #7176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
analyzers/src/SonarAnalyzer.Common/SymbolicExecution/Roslyn/OperationProcessors/Binary.cs
Show resolved
Hide resolved
pavel-mikula-sonarsource
force-pushed
the
Pavel/ComputeBool
branch
from
fa00159
to
319f219
Compare
Tim-Pohlmann
requested changes
May 5, 2023
analyzers/src/SonarAnalyzer.Common/SymbolicExecution/Roslyn/OperationProcessors/Binary.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/SymbolicExecution/Roslyn/OperationProcessors/Binary.cs
Show resolved
Hide resolved
.../tests/SonarAnalyzer.UnitTest/SymbolicExecution/Roslyn/RoslynSymbolicExecutionTest.Binary.cs
Show resolved
Hide resolved
...rAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/LocksReleasedAllPaths.Monitor.Loops.cs
Show resolved
Hide resolved
pavel-mikula-sonarsource
force-pushed
the
Pavel/ComputeBool
branch
from
6f4339f
to
7e9dcc5
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
SonarCloud Quality Gate failed. |
Tim-Pohlmann
approved these changes
May 9, 2023
| NumberConstraint.From(1, 1).IsSingleValue.Should().BeTrue(); | ||
| NumberConstraint.From(null, null).IsSingleValue.Should().BeFalse(); | ||
| NumberConstraint.From(null, 42).IsSingleValue.Should().BeFalse(); | ||
| NumberConstraint.From(42, null).IsSingleValue.Should().BeFalse(); |
There was a problem hiding this comment.
I know coverage is not a requirement for this PR, but this makes sense to test.
Suggested change
| NumberConstraint.From(42, null).IsSingleValue.Should().BeFalse(); | |
| NumberConstraint.From(42, null).IsSingleValue.Should().BeFalse(); | |
| NumberConstraint.Empty.IsSingleValue.Should().BeFalse(); |
There was a problem hiding this comment.
From(null, null) is already tested, so Empty will not change anything.
I don't really know what that line is not covered, we have
HasValue==true
HasValue==false
Min==Max
Min!=Max
There was a problem hiding this comment.
Oh! I think it's missing From(1, 42).
Additional note: I just changed the behavior of From(null, null) in #7174. You should change the test to use Empty instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7142
Fixes #2528
I'm not going to fix the coverage, because we need #7143 first