Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix breaking UTs by updating NFluent "IsPositive" calls #7183

Merged
merged 1 commit into from
May 8, 2023
Merged

Fix breaking UTs by updating NFluent "IsPositive" calls #7183

merged 1 commit into from
May 8, 2023

Conversation

gregory-paidis-sonarsource
Copy link
Contributor

Fixes breaking UTs

@github-actions github-actions bot added this to In progress in Best Kanban May 8, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented May 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gregory-paidis-sonarsource gregory-paidis-sonarsource marked this pull request as ready for review May 8, 2023 08:58
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban May 8, 2023
martin-strecker-sonarsource
martin-strecker-sonarsource approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The implementation only looks for invocations that have the NFluent.Check type as a container. The name of the methods is irrelevant.

@martin-strecker-sonarsource martin-strecker-sonarsource merged commit 457405c into master May 8, 2023
26 checks passed
Best Kanban automation moved this from Review in progress to Validate Peach May 8, 2023
@martin-strecker-sonarsource martin-strecker-sonarsource deleted the greg/fix-nfluent-is-positive branch May 8, 2023 09:29
@github-actions github-actions bot moved this from Validate Peach to Review approved in Best Kanban May 8, 2023
@pavel-mikula-sonarsource pavel-mikula-sonarsource moved this from Review approved to Validate Peach in Best Kanban May 8, 2023
@gregory-paidis-sonarsource gregory-paidis-sonarsource moved this from Validate Peach to Done in Best Kanban May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-strecker-sonarsource martin-strecker-sonarsource martin-strecker-sonarsource approved these changes

Assignees

@gregory-paidis-sonarsource gregory-paidis-sonarsource

Labels
None yet
Projects
Best Kanban
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gregory-paidis-sonarsource @martin-strecker-sonarsource