Update S1186: Change expcetion type in RPSEC #7587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
4 tasks
zsolt-kolbay-sonarsource
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
LGTM.
You have sharp eyes @nalka0, thank you for fixing this small mistake.
I've added a fix to the RSPEC document so the two don't get out of sync. I'll merge both PRs when that gets approved.
gregory-paidis-sonarsource
pushed a commit
to SonarSource/rspec
that referenced
this pull request
Jul 31, 2023
Related to [this community PR](SonarSource/sonar-dotnet#7587).
zsolt-kolbay-sonarsource
merged commit 4b25ebc
into
SonarSource:master
26 checks passed
zsolt-kolbay-sonarsource
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a (likely)
NotSupportedExceptioncopy paste mistake on S1186's html documentation