Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S2589 FN: No BoolConstraint from numerical constant patterns #7846

Merged
merged 5 commits into from
Aug 28, 2023
Merged

Fix S2589 FN: No BoolConstraint from numerical constant patterns #7846

merged 5 commits into from
Aug 28, 2023

Conversation

Tim-Pohlmann
Copy link
Contributor

Fixes #7780

@Tim-Pohlmann Tim-Pohlmann added the Sprint: SE Short-lived* label for epic MMF-3077 *troll label Aug 22, 2023
@Tim-Pohlmann Tim-Pohlmann removed the Sprint: SE Short-lived* label for epic MMF-3077 *troll label Aug 22, 2023
mary-georgiou-sonarsource
mary-georgiou-sonarsource requested changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good generally.
Just need to clarify if certain test case is possible.

analyzers/src/SonarAnalyzer.Common/SymbolicExecution/Constraints/NumberConstraint.cs Outdated Show resolved Hide resolved
analyzers/its/expected/Net5/Net5--net5.0-S2583.json
}
},
{
"uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/sources/Net5/Net5/S3440.cs#L10",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :D

mary-georgiou-sonarsource
mary-georgiou-sonarsource requested changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-assign me after the change we discussed.

@Tim-Pohlmann Tim-Pohlmann changed the title Fix S2589 FN: Capture numerical constrain knowledge Fix S2589 FN: No BoolConstraint from numerical constant patterns Aug 24, 2023
mary-georgiou-sonarsource
mary-georgiou-sonarsource requested changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests in RoslynSymbolicExecutionTest.PatternMatching.cs as the behavior it tests has been modified.

analyzers/src/SonarAnalyzer.Common/SymbolicExecution/Roslyn/OperationProcessors/IsPattern.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.Common/SymbolicExecution/Roslyn/OperationProcessors/IsPattern.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.Common/SymbolicExecution/Roslyn/OperationProcessors/IsPattern.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.Common/SymbolicExecution/Roslyn/OperationProcessors/IsPattern.cs Outdated Show resolved Hide resolved
mary-georgiou-sonarsource
mary-georgiou-sonarsource approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tiny nitpick

@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

94.4% 94.4% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@pavel-mikula-sonarsource pavel-mikula-sonarsource merged commit 8dba3bd into master Aug 28, 2023
32 of 33 checks passed
@pavel-mikula-sonarsource pavel-mikula-sonarsource deleted the Tim/IsPattern_NumberConstraint branch August 28, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mary-georgiou-sonarsource mary-georgiou-sonarsource mary-georgiou-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix S2589 FN: No BoolConstraint from numerical constant patterns
3 participants
@Tim-Pohlmann @mary-georgiou-sonarsource @pavel-mikula-sonarsource