Prevent issues from being reported when in Razor generated file or content after mapped back #7940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastien-marichal
force-pushed
the
sebastien/disable-issue-razor-generated-content
branch
from
435ed90
to
f704783
Compare
analyzers/src/SonarAnalyzer.Common/AnalysisContext/SonarSyntaxNodeReportingContext.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/AnalysisContext/SonarReportingContextBase.cs
Outdated
Show resolved
Hide resolved
csaba-sagi-sonarsource
suggested changes
Sep 4, 2023
|
Also, in theory once these changes are done we should be able to remove . If not then we will be able to remove it once the noisy rules for razor are disabled. |
sebastien-marichal
force-pushed
the
sebastien/razor-mapped-location
branch
3 times, most recently
from
06343be
to
3208b4c
Compare
sebastien-marichal
force-pushed
the
sebastien/disable-issue-razor-generated-content
branch
from
f704783
to
b3947bd
Compare
sebastien-marichal
force-pushed
the
sebastien/razor-mapped-location
branch
from
3208b4c
to
be172c4
Compare
sebastien-marichal
force-pushed
the
sebastien/disable-issue-razor-generated-content
branch
from
b3947bd
to
e52f1c9
Compare
sebastien-marichal
force-pushed
the
sebastien/disable-issue-razor-generated-content
branch
from
e52f1c9
to
d8fd500
Compare
sebastien-marichal
force-pushed
the
sebastien/disable-issue-razor-generated-content
branch
2 times, most recently
from
b24d40b
to
5ee622e
Compare
csaba-sagi-sonarsource
suggested changes
Sep 6, 2023
There was a problem hiding this comment.
Looks good, what I am afraid of is that we don't have a single intentional test that changes this change. Even the ITs that would fail are not the Razor or Blazor support samples that we added for razor blazor testing. The NetCore app It can be freely removed and from that point on we would have no tests.
Could you please add a UT on .net side and introduce some issues for the razor blazor app that would raise without your changes?
sebastien-marichal
force-pushed
the
sebastien/disable-issue-razor-generated-content
branch
from
5ee622e
to
77a761b
Compare
| { | ||
| using var scope = new EnvironmentVariableScope(false) { EnableRazorAnalysis = true }; | ||
| new VerifierBuilder() | ||
| .AddAnalyzer(() => new DummyAnalyzerRazorGeneratedCode()) |
There was a problem hiding this comment.
There is no need to create a new dummy analyzer. you can also you DummyCS to assert the functionality.
Suggested change
| .AddAnalyzer(() => new DummyAnalyzerRazorGeneratedCode()) | |
| .AddAnalyzer(() => new DummyCS()) |
csaba-sagi-sonarsource
approved these changes
Sep 8, 2023
- Prevent report if location still in generated content after location mapping - Do not analyse if SyntaxNode is in location that cannot be mapped to the original file
sebastien-marichal
force-pushed
the
sebastien/disable-issue-razor-generated-content
branch
from
77a761b
to
ca0c80e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
sebastien-marichal
deleted the
sebastien/disable-issue-razor-generated-content
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7930
Should be merged after #7932