ConditionEvaluatesToConstant: SyntaxWalker re-factoring #8215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-strecker-sonarsource
force-pushed
the
Martin/ConditionEvaluatesToConstant_SyntaxWalker
branch
from
29aff2a
to
4ef6d8b
Compare
github-actions
bot
assigned pavel-mikula-sonarsource and unassigned martin-strecker-sonarsource
pavel-mikula-sonarsource
requested changes
Nov 3, 2023
...nalyzer.UnitTest/Rules/SymbolicExecution/ConditionEvaluatesToConstantSyntaxKindWalkerTest.cs
Outdated
Show resolved
Hide resolved
...nalyzer.UnitTest/Rules/SymbolicExecution/ConditionEvaluatesToConstantSyntaxKindWalkerTest.cs
Outdated
Show resolved
Hide resolved
...nalyzer.UnitTest/Rules/SymbolicExecution/ConditionEvaluatesToConstantSyntaxKindWalkerTest.cs
Outdated
Show resolved
Hide resolved
...nalyzer.UnitTest/Rules/SymbolicExecution/ConditionEvaluatesToConstantSyntaxKindWalkerTest.cs
Outdated
Show resolved
Hide resolved
...nalyzer.UnitTest/Rules/SymbolicExecution/ConditionEvaluatesToConstantSyntaxKindWalkerTest.cs
Outdated
Show resolved
Hide resolved
...nalyzer.UnitTest/Rules/SymbolicExecution/ConditionEvaluatesToConstantSyntaxKindWalkerTest.cs
Outdated
Show resolved
Hide resolved
...nalyzer.UnitTest/Rules/SymbolicExecution/ConditionEvaluatesToConstantSyntaxKindWalkerTest.cs
Outdated
Show resolved
Hide resolved
...nalyzer.UnitTest/Rules/SymbolicExecution/ConditionEvaluatesToConstantSyntaxKindWalkerTest.cs
Outdated
Show resolved
Hide resolved
...nalyzer.UnitTest/Rules/SymbolicExecution/ConditionEvaluatesToConstantSyntaxKindWalkerTest.cs
Show resolved
Hide resolved
...yzers/src/SonarAnalyzer.VisualBasic/SymbolicExecution/Roslyn/ConditionEvaluatesToConstant.cs
Show resolved
Hide resolved
github-actions
bot
assigned martin-strecker-sonarsource and unassigned pavel-mikula-sonarsource
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
github-actions
bot
assigned pavel-mikula-sonarsource and unassigned martin-strecker-sonarsource
pavel-mikula-sonarsource
approved these changes
Nov 3, 2023
| } | ||
|
|
||
| [DataTestMethod] | ||
| [DataRow("""Dim x = 1 And 2""")] |
There was a problem hiding this comment.
The """ could be simplified to " (except one)
Comment on lines
+75
to
+76
| Dim x = From y in New Integer() { } | ||
| Where True |
There was a problem hiding this comment.
This can go on a single line, without :
Suggested change
| Dim x = From y in New Integer() { } | |
| Where True | |
| Dim x = From y in New Integer() { } Where True |
github-actions
bot
assigned martin-strecker-sonarsource and unassigned pavel-mikula-sonarsource
martin-strecker-sonarsource
deleted the
Martin/ConditionEvaluatesToConstant_SyntaxWalker
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #8103
This PR fixes the params array allocation caused by
IsAnyKindand reactors the SyntaxWalker to do the SyntaxKind checks in the dedicated Visit... methods. That way the number of comparisons is reduced.