NullPointerDereference.SyntaxKindWalker reduce allocations and evaluations in the hot path #8385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-strecker-sonarsource
requested review from
pavel-mikula-sonarsource and
sebastien-marichal
github-actions
bot
assigned pavel-mikula-sonarsource and unassigned martin-strecker-sonarsource
pavel-mikula-sonarsource
approved these changes
Nov 21, 2023
|
|
||
| public override void VisitMemberAccessExpression(MemberAccessExpressionSyntax node) | ||
| { | ||
| if (node.Kind() is SyntaxKind.SimpleMemberAccessExpression) |
There was a problem hiding this comment.
It's not really a pattern to match
Suggested change
| if (node.Kind() is SyntaxKind.SimpleMemberAccessExpression) | |
| if (node.Kind() == SyntaxKind.SimpleMemberAccessExpression) |
| { | ||
| public bool Result { get; private set; } | ||
|
|
||
| public override void Visit(SyntaxNode node) | ||
| { | ||
| Result |= node.Kind() is SyntaxKindEx.ForEachVariableStatement; |
There was a problem hiding this comment.
It's simple int comparison
Suggested change
| Result |= node.Kind() is SyntaxKindEx.ForEachVariableStatement; | |
| Result |= node.Kind() == SyntaxKindEx.ForEachVariableStatement; |
| { | ||
| public bool Result { get; private set; } | ||
|
|
||
| public override void Visit(SyntaxNode node) | ||
| { | ||
| Result |= node.Kind() is SyntaxKindEx.ForEachVariableStatement; |
There was a problem hiding this comment.
That's so annoying that it's a different syntax kind :/ We're likely missing it all over the place
analyzers/src/SonarAnalyzer.VisualBasic/SymbolicExecution/Roslyn/NullPointerDereference.cs
Show resolved
Hide resolved
...onarAnalyzer.UnitTest/Rules/SymbolicExecution/NullPointerDereferenceSyntaxKindWalkerTests.cs
Outdated
Show resolved
Hide resolved
| { | ||
| public unsafe void M(int i) | ||
| { | ||
| int* iPtr = &i; |
There was a problem hiding this comment.
You can use int* iPtr argument directly, to avoid this scaffolding.
...onarAnalyzer.UnitTest/Rules/SymbolicExecution/NullPointerDereferenceSyntaxKindWalkerTests.cs
Show resolved
Hide resolved
...onarAnalyzer.UnitTest/Rules/SymbolicExecution/NullPointerDereferenceSyntaxKindWalkerTests.cs
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| [DataTestMethod] | ||
| [DataRow("""Dim i As System.Int32""")] |
There was a problem hiding this comment.
This doesn't need to be a DataTestMethod. Or you can add this, to make it similar to the C# version
[DataRow("""Dim S As String = (ToString()?.Length)?.ToString()""")]
| public class NullPointerDereferenceSyntaxKindWalkerTests | ||
| { | ||
| [DataTestMethod] | ||
| [DataRow("""await Task.Yield();""")] |
There was a problem hiding this comment.
None of the DataRow needs """. Simple string is enough in all cases
github-actions
bot
assigned martin-strecker-sonarsource and unassigned sebastien-marichal
github-actions
bot
moved this from Review in progress
to Review approved
in Best Kanban
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
martin-strecker-sonarsource
deleted the
Martin/NullPointerDereference_SyntaxWalker
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #8103
This PR fixes the params array allocation caused by IsAnyKind and reactors the SyntaxWalker to do the SyntaxKind checks in the dedicated Visit... methods. That way the number of comparisons is reduced.