S1144: Add FP/FN Repro for #8532 #8534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tim-Pohlmann
force-pushed
the
Tim/S1144_SeralizableRepro
branch
from
d78e412
to
7618163
Compare
|
@Tim-Pohlmann The rename of "UnitTest" directory was merged to master, that's why there's a conflict |
|
Yes, thanks. I will rebase. |
Tim-Pohlmann
force-pushed
the
Tim/S1144_SeralizableRepro
branch
from
7618163
to
38d2d5a
Compare
|
|
antonioaversa
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
LGTM
@Tim-Pohlmann I think exceptions should be added to the RSPEC of S1144: the only exception mentioned there, related to SerializableAttribute is "empty serialization constructor", which doesn't capture the scenarios reproduced in this PR. If you agree, #8532 should mention to extend the RSPEC accordingly.
github-actions
bot
moved this from Review in progress
to Review approved
in Best Kanban
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repro for #8532