Fix S2583/2589 FP: Return inside lock, using and finally causes FP after the block #8761
Conversation
|
|
| var current = FinallyPoint; | ||
| while (current is not null && other is not null) | ||
| { | ||
| if (current.BlockIndex == other.BlockIndex && current.BranchDestination == other.BranchDestination) |
There was a problem hiding this comment.
Suggestion: Could this line be an equals override in FinallyPoint?
And then you just check current.Equals(other)?
Looking at the codebase, this is the only point that you ever compare finally points.
Or more correctly maybe, the entire method should be inside Equals
There was a problem hiding this comment.
That was my initial implementation and I didn't go that way, because this logic is strictly bound to what ExplodedNode needs.
Such Equals would ignore that the branches are different, and are possibly from different source blocks. So I didn't want to use Equals for that.
Fixes #8678
Fixes #8495
There's one commit that does the raw string literal clenup in isolation. The actual change is small