Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New rule S6673: Log message template placeholders should be in the right order #8859

Merged
merged 6 commits into from
Mar 7, 2024

Conversation

zsolt-kolbay-sonarsource
Copy link
Contributor

Fixes #8769

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, this is probably the most annoying rule of BOTH the logging sprints. :)
I left a few improvements on the implementation, please take a look and feel free to challenge any of them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good!
I left a couple final comments, please take a look.

Copy link

sonarcloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Mar 7, 2024

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looksgoodtome!

@gregory-paidis-sonarsource gregory-paidis-sonarsource merged commit 3cf7728 into master Mar 7, 2024
27 checks passed
@gregory-paidis-sonarsource gregory-paidis-sonarsource deleted the Zsolt/new-rule-S6673 branch March 7, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New rule S6673: Log message template placeholders should be in the right order
2 participants