Fix S3993 FP: Allow abstract attributes not to decorate Attribute usage

[Corniel]

As reported at Sonar Community, Abstract attributes should not report S3993.

Not that due to the latest changes, I can not build Sonar locally, as I have no JFrog account, and I could not find how to set this up in the documentation.

[antonioaversa]

Not that due to the latest changes, I can not build Sonar locally, as I have no JFrog account, and I could not find how to set this up in the documentation.

Hi @Corniel, I think the following action from the Building, Testing and Debugging the .NET Analyzer page should help:

Before following any of the guides below, if you are external contributor you need to delete analyzers\NuGet.Config.

So it should be as easy as removing the file, and no further configuration on JFrog should be required.
Let me know if that works for you.

[Corniel]

@antonioaversa It does the trick.

[antonioaversa]

LGTM, I left a couple of optional comments to clean variable names in lambda, that pre-existed this PR.

[antonioaversa]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[antonioaversa]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[antonioaversa]

@Corniel All good, the PR is merged and it's going to make it for the next release. Thanks for this contribution!

[martin-strecker-sonarsource]

Peach validation:
33 Lost issues - all true negatives.