Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move NetX project from .NET ITs to Java ITs #8929

Merged
merged 6 commits into from
Mar 20, 2024
Merged

Move NetX project from .NET ITs to Java ITs #8929

merged 6 commits into from
Mar 20, 2024

Conversation

gregory-paidis-sonarsource
Copy link
Contributor

@gregory-paidis-sonarsource gregory-paidis-sonarsource commented Mar 14, 2024 •
edited
Loading

Part of #8921
Moves everything else after Net5 was merged.

@gregory-paidis-sonarsource gregory-paidis-sonarsource added the Area: C# C# rules related issues. label Mar 14, 2024
@github-actions github-actions bot added this to In progress in Best Kanban Mar 14, 2024
Base automatically changed from greg/migrate-net5-to-java-its to master March 20, 2024 12:38
@gregory-paidis-sonarsource gregory-paidis-sonarsource marked this pull request as ready for review March 20, 2024 12:46
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban Mar 20, 2024
pavel-mikula-sonarsource
pavel-mikula-sonarsource approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

analyzers/its/update-expected.ps1 Outdated Show resolved Hide resolved
its/src/test/java/com/sonar/it/csharp/SdkTest.java Outdated Show resolved Hide resolved
its/src/test/java/com/sonar/it/csharp/SdkTest.java Show resolved Hide resolved
@pavel-mikula-sonarsource pavel-mikula-sonarsource moved this from Review in progress to Review approved in Best Kanban Mar 20, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@gregory-paidis-sonarsource gregory-paidis-sonarsource merged commit 08ef245 into master Mar 20, 2024
25 checks passed
Best Kanban automation moved this from Review approved to Validate Peach Mar 20, 2024
@gregory-paidis-sonarsource gregory-paidis-sonarsource deleted the greg/migrate-sdk-net-its branch March 20, 2024 16:34
@gregory-paidis-sonarsource gregory-paidis-sonarsource moved this from Validate Peach to Done in Best Kanban Mar 20, 2024
@costin-zaharia-sonarsource costin-zaharia-sonarsource mentioned this pull request May 29, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavel-mikula-sonarsource pavel-mikula-sonarsource pavel-mikula-sonarsource approved these changes

Assignees

@gregory-paidis-sonarsource gregory-paidis-sonarsource

Labels
Area: C# C# rules related issues.
Projects
Best Kanban
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gregory-paidis-sonarsource @pavel-mikula-sonarsource