Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create rule S6932: Use model binding instead of reading raw request data #8930

Closed
wants to merge 62 commits into from
Closed

Create rule S6932: Use model binding instead of reading raw request data #8930

wants to merge 62 commits into from

Commits on Mar 14, 2024

  1. WIP: Add the RegisterSymbolStart wrapper

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    79b5811 View commit details
    Browse the repository at this point in the history

  2. Clean up

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    d2c4e6c View commit details
    Browse the repository at this point in the history

  3. Rename

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    f09a581 View commit details
    Browse the repository at this point in the history

  4. Add RegisterCodeBlockStartActionCS and RegisterOperationAction

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    15659e6 View commit details
    Browse the repository at this point in the history

  5. Add remaining register methods

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    3a72741 View commit details
    Browse the repository at this point in the history

  6. Clean up

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    f56b0d2 View commit details
    Browse the repository at this point in the history

  7. Add tests for missing VB support

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    203a1d0 View commit details
    Browse the repository at this point in the history

  8. Add comments

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    aa567ef View commit details
    Browse the repository at this point in the history

  9. Move TestDiagnosticAnalyzer

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    02d7aa7 View commit details
    Browse the repository at this point in the history

  10. Cleanup

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    7deaaec View commit details
    Browse the repository at this point in the history

  11. Use property accessor instead of passing per ctor

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    383b87f View commit details
    Browse the repository at this point in the history

  12. Move registerCodeBlockAction and registerCodeBlockStartActionCS to Sy… 

    …mbolStartAnalysisContext
    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    2a2ffaa View commit details
    Browse the repository at this point in the history

  13. Move registerOperationAction

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    2c60f8c View commit details
    Browse the repository at this point in the history

  14. Move registerOperationBlockAction, registerOperationBlockStartAction,… 

    … and registerSymbolEndAction
    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    927639a View commit details
    Browse the repository at this point in the history

  15. Move registerSyntaxNodeActionCS

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    d31f523 View commit details
    Browse the repository at this point in the history

  16. Move comments

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    43ec236 View commit details
    Browse the repository at this point in the history

  17. Make SymbolStartAnalysisContext a readonly struct

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    7e8d31d View commit details
    Browse the repository at this point in the history

  18. Code review.

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    8142b5c View commit details
    Browse the repository at this point in the history

  19. Refactorings

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    99a523b View commit details
    Browse the repository at this point in the history

  20. Improve RegisterSymbolStartAction_SymbolStartProperties

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    2743a4e View commit details
    Browse the repository at this point in the history

  21. Add support for VB

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    8e64f8e View commit details
    Browse the repository at this point in the history

  22. Add packages.lock.json

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    6cd98dc View commit details
    Browse the repository at this point in the history

  23. Remove packages.locks.json (VS created it after re-base)

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    f5922df View commit details
    Browse the repository at this point in the history

  24. Rename SymbolStartAnalysisContext to SymbolStartAnalysisContextWrapper

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    f83cb2c View commit details
    Browse the repository at this point in the history

  25. Make fields readonly and rename

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    dd1a605 View commit details
    Browse the repository at this point in the history

  26. Move property

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    9c9f0c5 View commit details
    Browse the repository at this point in the history

  27. Remove alias

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    0c1ff8a View commit details
    Browse the repository at this point in the history

  28. Inline "code" variable

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    f259d3e View commit details
    Browse the repository at this point in the history

  29. Add RegisterSymbolStartAction_RegisterCodeBlockAction_ConditionalRegi… 

    …stration
    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    a07b70b View commit details
    Browse the repository at this point in the history

  30. Improve test coverage

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    d5f16fb View commit details
    Browse the repository at this point in the history

  31. Scaffold rule with ./scripts/rspec/rspec -language cs -ruleKey S6932 … 

    …-rspecBranch "rule/add-RSPEC-S6932" ClassName
    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    93c9cb5 View commit details
    Browse the repository at this point in the history

  32. Add registrations for asp.net core controller

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    19d418f View commit details
    Browse the repository at this point in the history

  33. Pick changes from Martin/S2077_PetaPoco2 branch

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    6204f53 View commit details
    Browse the repository at this point in the history

  34. Use tracker

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    b067076 View commit details
    Browse the repository at this point in the history

  35. Add support for Form access

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    e3de32e View commit details
    Browse the repository at this point in the history

  36. Comments

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    af82bbc View commit details
    Browse the repository at this point in the history

  37. Support all NonCompliant cases

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    942252f View commit details
    Browse the repository at this point in the history

  38. Add support for overrides

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    f35eb46 View commit details
    Browse the repository at this point in the history

  39. Add IsOverridingFilterMethods and use ConcurrentStack

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    c1726a3 View commit details
    Browse the repository at this point in the history

  40. Extract descriptors

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    a084719 View commit details
    Browse the repository at this point in the history

  41. Re-factor

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    1dfab22 View commit details
    Browse the repository at this point in the history

  42. Styling

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    af98074 View commit details
    Browse the repository at this point in the history

  43. Add invokedMemberNodeConstraint to ArgumentDescriptor

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    3ca6b46 View commit details
    Browse the repository at this point in the history

  44. Refactor and comments

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    892d211 View commit details
    Browse the repository at this point in the history

  45. Fix UT

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    460d2ca View commit details
    Browse the repository at this point in the history

  46. Use LanguageFacade

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    1b61e74 View commit details
    Browse the repository at this point in the history

  47. Collection expression

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    259c7cf View commit details
    Browse the repository at this point in the history

  48. Add Request.RouteValues write test case and simplify descriptors. Pas… 

    …s descriptors as array to avoid re-allocations
    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    6131b53 View commit details
    Browse the repository at this point in the history

  49. Move Compliant() and NoncompliantKeyVariations to parameterized tests.

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    ae75770 View commit details
    Browse the repository at this point in the history

  50. Add CombinatorialDataAttribute

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    173fb53 View commit details
    Browse the repository at this point in the history

  51. Move remaining parameterized tests

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    7efce24 View commit details
    Browse the repository at this point in the history

  52. Fix after re-base

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    c1d3ad0 View commit details
    Browse the repository at this point in the history

  53. EOF

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    383e5a5 View commit details
    Browse the repository at this point in the history

  54. Code smells

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    016edfa View commit details
    Browse the repository at this point in the history

  55. Add DottedExpressions tests and ElementAccess/Binding

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    bbe60e8 View commit details
    Browse the repository at this point in the history

  56. Fix CAE handling

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    cd149e1 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Review

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    e8ec464 View commit details
    Browse the repository at this point in the history

  2. Rename rule.

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    a157346 View commit details
    Browse the repository at this point in the history

  3. Rename test file

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    053e04f View commit details
    Browse the repository at this point in the history

  4. Move IsOverridingFilterMethods logic

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    26b0d76 View commit details
    Browse the repository at this point in the history

  5. Review

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    d1b9fea View commit details
    Browse the repository at this point in the history

  6. Review

    @martin-strecker-sonarsource
    martin-strecker-sonarsource committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    1d95916 View commit details
    Browse the repository at this point in the history