Add Argument tracker and tests #8950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This was referenced Mar 18, 2024
martin-strecker-sonarsource
force-pushed
the
Martin/ArgumentDescriptor
branch
from
094e1ee
to
b892fbb
Compare
|
github-actions
bot
assigned zsolt-kolbay-sonarsource and unassigned martin-strecker-sonarsource
github-actions
bot
assigned costin-zaharia-sonarsource and unassigned zsolt-kolbay-sonarsource
martin-strecker-sonarsource
assigned zsolt-kolbay-sonarsource and unassigned zsolt-kolbay-sonarsource
costin-zaharia-sonarsource
requested changes
Apr 25, 2024
analyzers/src/SonarAnalyzer.CSharp/Helpers/CSharpAttributeParameterLookup.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Helpers/CSharpMethodParameterLookup.cs
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Helpers/ArgumentDescriptor.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Helpers/ArgumentDescriptor.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Helpers/ArgumentDescriptor.cs
Outdated
Show resolved
Hide resolved
github-actions
bot
assigned martin-strecker-sonarsource and unassigned costin-zaharia-sonarsource
costin-zaharia-sonarsource
requested changes
Apr 25, 2024
analyzers/src/SonarAnalyzer.Common/Helpers/ArgumentDescriptor.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Helpers/ArgumentDescriptor.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.VisualBasic/Extensions/SyntaxNodeExtensions.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Helpers/MethodParameterLookupBase.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Helpers/MethodParameterLookupBase.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Helpers/MethodParameterLookupBase.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.VisualBasic/Helpers/VisualBasicAttributeParameterLookup.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Trackers/CSharpArgumentTracker.cs
Outdated
Show resolved
Hide resolved
| && Language.MethodParameterLookup(invoked, methodSymbol).TryGetSymbol(argumentNode, out var parameter) | ||
| && ParameterFits(parameter, descriptor.ParameterConstraint, descriptor.InvokedMemberConstraint)) | ||
| { | ||
| context.Parameter = parameter; |
There was a problem hiding this comment.
I find it very confusing that this method has side effects. Will this used only in tests?
There was a problem hiding this comment.
Will this used only in tests?
Unfortunately not. The rule PR uses this call.
this method has side effects
Yes. This is very unfortunate. There should be a distinction between input and output, but the context is both at the moment. This is how the tracker is designed now: It creates a pipeline of matchers and passes the context from one to the others. Each matcher can manipulate parts of the context. (It's a bit like the request pipeline in asp.net core).
analyzers/src/SonarAnalyzer.VisualBasic/Trackers/VisualBasicArgumentTracker.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.VisualBasic/Trackers/VisualBasicArgumentTracker.cs
Show resolved
Hide resolved
martin-strecker-sonarsource
force-pushed
the
Martin/ArgumentDescriptor
branch
from
70f5741
to
f798a43
Compare
costin-zaharia-sonarsource
moved this from Review in progress
to In progress
in Best Kanban
costin-zaharia-sonarsource
assigned martin-strecker-sonarsource and unassigned costin-zaharia-sonarsource
costin-zaharia-sonarsource
force-pushed
the
feature/New_S6932
branch
from
5631cb6
to
b5becf0
Compare
martin-strecker-sonarsource
force-pushed
the
Martin/ArgumentDescriptor
branch
from
f798a43
to
f71058e
Compare
costin-zaharia-sonarsource
force-pushed
the
feature/New_S6932
branch
from
b5becf0
to
529ed91
Compare
costin-zaharia-sonarsource
force-pushed
the
Martin/ArgumentDescriptor
branch
from
a907dbd
to
e0d6cf2
Compare
|
|
costin-zaharia-sonarsource
merged commit c117342
into
feature/New_S6932
25 of 26 checks passed
costin-zaharia-sonarsource
pushed a commit
that referenced
this pull request
May 15, 2024
Co-authored-by: Gregory Paidis <gregory.paidis@sonarsource.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an ArgumentDescriptor and logic to match an ArgumentSyntax against it.
Based on #8947