Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the expected plugin file size #8958

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

costin-zaharia-sonarsource
Copy link
Member

No description provided.

Copy link

sonarcloud bot commented Mar 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Mar 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban Mar 19, 2024
Copy link
Contributor

@sebastien-marichal sebastien-marichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The size update is not the same for maxsize and minsize for C#.
I just want to make sure this is intended.

sonar-csharp-plugin/pom.xml Show resolved Hide resolved
@github-actions github-actions bot moved this from Review in progress to In progress in Best Kanban Mar 19, 2024
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban Mar 19, 2024
Copy link
Contributor

@sebastien-marichal sebastien-marichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot moved this from Review in progress to Review approved in Best Kanban Mar 19, 2024
@costin-zaharia-sonarsource costin-zaharia-sonarsource merged commit 28b72bb into master Mar 19, 2024
34 checks passed
Best Kanban automation moved this from Review approved to Validate Peach Mar 19, 2024
@costin-zaharia-sonarsource costin-zaharia-sonarsource deleted the costin/fix-master branch March 19, 2024 15:48
@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource moved this from Validate Peach to Done in Best Kanban Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Best Kanban
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants