Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify registration extensions #9049

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

pavel-mikula-sonarsource
Copy link
Contributor

These SonarAnalysisContextExtensions.cs are specific to a language (CSharp vs. VisualBasic) therefore their TSyntaxKind is already given by the project they reside in.

Generic argument is needed only in the layer below these files.

Copy link

sonarcloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Apr 9, 2024

Copy link
Contributor

@sebastien-marichal sebastien-marichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I am surprised to see so few changes.

@sebastien-marichal sebastien-marichal merged commit 8f54a08 into master Apr 9, 2024
30 checks passed
Best Kanban automation moved this from Review in progress to Validate Peach Apr 9, 2024
@sebastien-marichal sebastien-marichal deleted the Pavel/Registration branch April 9, 2024 11:51
@pavel-mikula-sonarsource pavel-mikula-sonarsource moved this from Validate Peach to Done in Best Kanban Apr 10, 2024
@pavel-mikula-sonarsource pavel-mikula-sonarsource added the Type: Tooling Tools make us productive. label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Tooling Tools make us productive.
Projects
Best Kanban
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants