Fix S3878 FP: Jagged arrays #9102
Conversation
| @@ -95,7 +95,7 @@ public void CallMethod() | |||
| MethodArray(new String[] { "1", "2" }, new String[] { "1", "2" }); // Noncompliant, FP. Elements in args: [System.String[], System.String[]] | |||
| MethodArray(new int[] { 1, 2 }, new int[] { 1, 2 }); // Noncompliant, FP. Elements in args: [System.Int32[], System.Int32[]] | |||
|
|
|||
| MethodJuggedArray(new int[] { 1, 2 }); // Noncompliant, FP. Elements in args: [System.Object[]] | |||
| MethodJuggedArray(new int[] { 1, 2 }); // Compliant: jagged array [System.Object[]] | |||
There was a problem hiding this comment.
jugged :D
| MethodJuggedArray(new int[] { 1, 2 }); // Compliant: jagged array [System.Object[]] | |
| MethodJaggedArray(new int[] { 1, 2 }); // Compliant: jagged array [System.Object[]] |
| : null; | ||
|
|
||
| private static bool IsJaggedArrayParam(IParameterSymbol param) => | ||
| param.Type is IArrayTypeSymbol { ElementType: IArrayTypeSymbol }; |
There was a problem hiding this comment.
param.Type is always IArrayTypeSymbol, correct? I wonder if a direct cast would be more explicit here. Then again... I like the pattern-matching syntax :D
There was a problem hiding this comment.
I swear I replied but I don't see the message now for some reason. Anyway not always, but in this particular implementation, we are checking previously that the parameter is an array. So yes, that part will always be true. But I would leave the pattern-matching because it's quite neat IMO
There was a problem hiding this comment.
It seems like it affects coverage:
I'm ok with accepting it as defensive programming.
|
|
Fixes #8163