-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Rule T0009: Order the same member kind by its accessibility #9136
Conversation
b6483c5
to
ef33ba7
Compare
ef33ba7
to
5e74ac6
Compare
Quality Gate passedIssues Measures |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I left a non-blocking comment.
private int private1; | ||
|
||
protected int protectedVariant1; // Noncompliant {{Move this protected Field above the private ones.}} | ||
private protected int protectedVariant2; // Noncompliant {{Move this protected Field above the private ones.}} | ||
protected internal int protectedVariant3; // Noncompliant {{Move this protected Field above the private ones.}} | ||
|
||
public int publicOrInternal1; // Noncompliant {{Move this public Field above the private ones.}} | ||
internal int publicOrInternal2; // Noncompliant {{Move this internal Field above the private ones.}} | ||
public int publicOrInternal3; // Noncompliant {{Move this public Field above the private ones.}} | ||
internal int publicOrInternal4; // Noncompliant {{Move this internal Field above the private ones.}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was confused by why all the issues had the same message before I realized they were all talking about the first field.
If not too much effort, we could add a secondary location.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #9045