UTs: Replace Moq with NSubsitute #9206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavel-mikula-sonarsource
force-pushed
the
Pavel/NSubstitute
branch
from
91e088a
to
b0af752
Compare
CristianAmbrosini
approved these changes
Apr 29, 2024
| tree.SetupGet(x => x.Encoding).Returns(() => null); | ||
| var tree = Substitute.For<SyntaxTree>(); | ||
| tree.FilePath.Returns("File.Generated.cs"); // Generated to simplify mocking for GeneratedCodeRecognizer | ||
| tree.Encoding.Returns(x => null); |
There was a problem hiding this comment.
Suggested change
| tree.Encoding.Returns(x => null); | |
| tree.Encoding.Returns(_ => null); |
There was a problem hiding this comment.
I don't like discards on the source side. The x doesn't cost anything, the _ costs changing it to x incase we'd use it in the future
|
@pavel-mikula-sonarsource this was approved with a minor comment, I'm not sure why the card didn't move to the approved column. Feel free to merge after rebase |
pavel-mikula-sonarsource
force-pushed
the
Pavel/NSubstitute
branch
from
6b073ed
to
1ebfdb0
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.