Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable razor UTs in-memory compilation #9226

Merged
merged 11 commits into from
May 2, 2024
Merged

Enable razor UTs in-memory compilation #9226

merged 11 commits into from
May 2, 2024

Conversation

Tim-Pohlmann
Copy link
Contributor

@Tim-Pohlmann Tim-Pohlmann commented Apr 30, 2024

Fixes #9010

This includes the previously reverted PR #9190 and additional fixes that were needed to make it work.

Copy link
Contributor

@CristianAmbrosini CristianAmbrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few ideas/questions

Tim-Pohlmann and others added 8 commits May 2, 2024 11:41
Co-authored-by: Sebastien Marichal <sebastien.marichal@sonarsource.com>

# Conflicts:
#	analyzers/tests/SonarAnalyzer.Test/Rules/Utilities/SymbolReferenceAnalyzerTest.cs
#	analyzers/tests/SonarAnalyzer.Test/TestCases/Utilities/SymbolReferenceAnalyzer/Razor.razor
Copy link
Contributor

@CristianAmbrosini CristianAmbrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Tim-Pohlmann Tim-Pohlmann enabled auto-merge (squash) May 2, 2024 09:45
Copy link

sonarcloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed for 'Sonar .NET Java Plugin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 2, 2024

@Tim-Pohlmann Tim-Pohlmann merged commit c755a17 into master May 2, 2024
26 checks passed
@Tim-Pohlmann Tim-Pohlmann deleted the Tim/RazorUTs branch May 2, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable razor UTs in-memory compilation
2 participants