-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable razor UTs in-memory compilation #9226
Conversation
d7fc1a8
to
2d07075
Compare
2d07075
to
cbd2276
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few ideas/questions
analyzers/tests/SonarAnalyzer.Test/Rules/AvoidLambdaExpressionInLoopsInBlazorTest.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.Test/Rules/AvoidLambdaExpressionInLoopsInBlazorTest.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.Test/Rules/BlazorQueryParameterRoutableComponentTest.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.Test/Rules/ConditionalStructureSameConditionTest.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.Test/Rules/ConditionalStructureSameImplementationTest.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.Test/Rules/Utilities/SymbolReferenceAnalyzerTest.cs
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.TestFramework/Verification/Verifier.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.TestFramework/Verification/Verifier.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Sebastien Marichal <sebastien.marichal@sonarsource.com> # Conflicts: # analyzers/tests/SonarAnalyzer.Test/Rules/Utilities/SymbolReferenceAnalyzerTest.cs # analyzers/tests/SonarAnalyzer.Test/TestCases/Utilities/SymbolReferenceAnalyzer/Razor.razor
…es => there will be no content files)
analyzers/tests/SonarAnalyzer.Test/Rules/UnnecessaryUsingsTest.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Quality Gate passed for 'Sonar .NET Java Plugin'Issues Measures |
Quality Gate passed for 'SonarAnalyzer for .NET'Issues Measures |
Fixes #9010
This includes the previously reverted PR #9190 and additional fixes that were needed to make it work.