Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repro for FN 2589: Support redundant recursive pattern null check #9234

Merged
merged 2 commits into from
May 2, 2024

Conversation

gregory-paidis-sonarsource
Copy link
Contributor

Repro for #9203

@github-actions github-actions bot added this to In progress in Best Kanban May 1, 2024
@gregory-paidis-sonarsource gregory-paidis-sonarsource marked this pull request as ready for review May 1, 2024 10:44
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban May 1, 2024
Copy link
Contributor

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left two small comments.

@github-actions github-actions bot moved this from Review in progress to Review approved in Best Kanban May 1, 2024
Copy link

sonarcloud bot commented May 1, 2024

Quality Gate Passed Quality Gate passed for 'Sonar .NET Java Plugin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 1, 2024

Quality Gate Passed Quality Gate passed for 'SonarAnalyzer for .NET'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@gregory-paidis-sonarsource gregory-paidis-sonarsource merged commit 75e2d7b into master May 2, 2024
27 checks passed
@gregory-paidis-sonarsource gregory-paidis-sonarsource deleted the greg/repro_9203 branch May 2, 2024 08:07
Best Kanban automation moved this from Review approved to Validate Peach May 2, 2024
@gregory-paidis-sonarsource gregory-paidis-sonarsource moved this from Validate Peach to Done in Best Kanban May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Best Kanban
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants