Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S2629: Add Repro for #9247 #9248

Merged
merged 1 commit into from
May 6, 2024
Merged

S2629: Add Repro for #9247 #9248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions analyzers/tests/SonarAnalyzer.Test/TestCases/UseConstantLoggingTemplate.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ public void BasicScenarios(ILogger logger, int arg)
logger.Log(LogLevel.Warning, "First " + "Second " + "Third"); // Compliant - all strings in the concatenation are constants, the compiler can optimize it
logger.Log(LogLevel.Warning, FieldConstant + localConstant); // Compliant
logger.Log(LogLevel.Warning, FieldConstant + "Second"); // Compliant
logger.Log(LogLevel.Warning, $"Constant: {FieldConstant}"); // Noncompliant FP Repro https://github.com/SonarSource/sonar-dotnet/issues/9247
logger.Log(LogLevel.Warning, "First " + arg + "Third"); // Noncompliant
logger.Log(LogLevel.Warning, ("First " + "Second").ToLower()); // FN

Expand Down