Fix S2234 Bug: AD0001 is thrown due to referencing a location outside of the current compilation #9323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-strecker-sonarsource
approved these changes
May 23, 2024
analyzers/src/SonarAnalyzer.Common/Rules/ParametersCorrectOrderBase.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.Test/Rules/ParametersCorrectOrderTest.cs
Outdated
Show resolved
Hide resolved
pavel-mikula-sonarsource
force-pushed
the
Pavel/SecondaryLocations
branch
from
f5edbf6
to
4bf10b9
Compare
pavel-mikula-sonarsource
force-pushed
the
Pavel/AD0001
branch
from
f904f11
to
4e61248
Compare
|
|
This was referenced May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8577
1st commit adds a reproducer, 2nd fixes it by using the new overloads from #9298