Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S6781: Implement ShouldExecute #9345

Merged
merged 4 commits into from
May 30, 2024

Conversation

gregory-paidis-sonarsource
Copy link
Contributor

@gregory-paidis-sonarsource gregory-paidis-sonarsource commented May 28, 2024

Part of #8996

Commit 1: Implementation
Commit 2: Fix typo

DO NOT merge until #9324 is merged.
Please leave as draft.

Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot moved this from Review in progress to Review approved in Best Kanban May 28, 2024
Base automatically changed from costin/S6781 to master May 29, 2024 13:54
@costin-zaharia-sonarsource costin-zaharia-sonarsource force-pushed the greg/S6781-should-execute branch 2 times, most recently from 018da55 to 06933e5 Compare May 29, 2024 15:16
@costin-zaharia-sonarsource costin-zaharia-sonarsource marked this pull request as ready for review May 29, 2024 15:17
Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Passed Quality Gate passed for 'Sonar .NET Java Plugin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 29, 2024

Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot moved this from Review in progress to Review approved in Best Kanban May 30, 2024
@costin-zaharia-sonarsource costin-zaharia-sonarsource merged commit 4cefc0f into master May 30, 2024
29 checks passed
Best Kanban automation moved this from Review approved to Validate Peach May 30, 2024
@costin-zaharia-sonarsource costin-zaharia-sonarsource deleted the greg/S6781-should-execute branch May 30, 2024 08:38
@costin-zaharia-sonarsource costin-zaharia-sonarsource moved this from Validate Peach to Done in Best Kanban May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Best Kanban
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants