Update Shim Layer: Add wrappers for C# 12 Operations #9365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| @@ -3387,4 +3402,70 @@ | |||
| </Comments> | |||
| </Property> | |||
| </Node> | |||
| </Tree> | |||
| <Node Name="ICollectionExpressionOperation" Base="IOperation" HasType="true"> | |||
There was a problem hiding this comment.
The only non-formatting change in the file starts here.
There was a problem hiding this comment.
? were removed from the signatures on purpose
github-actions
bot
assigned pavel-mikula-sonarsource and unassigned zsolt-kolbay-sonarsource
github-actions
bot
assigned zsolt-kolbay-sonarsource and unassigned pavel-mikula-sonarsource
github-actions
bot
moved this from Review in progress
to Review approved
in Best Kanban
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add wrappers for
ICollectionExpressionOperationandISpreadOperation.Done by copying the OperationInterfaces.xml from the Roslyn repo and removing the nullable reference types with find/replace.
Most of the changes are formatting, the only real changes are at the bottom of the file (the two new interfaces).