-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix S2737 FP: Raised when exception filter is used #9385
Conversation
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -58,7 +58,7 @@ Namespace Tests.TestCases | |||
|
|||
Try | |||
doSomething() | |||
Catch exc As ArgumentException When True 'Noncompliant | |||
Catch exc As ArgumentException When True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Catch exc As ArgumentException When True | |
Catch exc As ArgumentException When True ' FN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll consider the True
just a scaffolding noise. It's not a SE rule to determine if the expression is always true
Fixes #8199