Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated ReportIssue in more locations #9423

Merged
merged 10 commits into from
Jun 14, 2024
Merged

Replace deprecated ReportIssue in more locations #9423

merged 10 commits into from
Jun 14, 2024

Conversation

martin-strecker-sonarsource
Copy link
Contributor

@martin-strecker-sonarsource martin-strecker-sonarsource commented Jun 11, 2024 •
edited
Loading

Follow up on #9422
Replaces 5 of the remaining 12 calls.

@github-actions github-actions bot added this to In progress in Best Kanban Jun 11, 2024
@martin-strecker-sonarsource martin-strecker-sonarsource changed the title Martin/report issue remaining Replace deprecated ReportIssue in more locations Jun 11, 2024
@martin-strecker-sonarsource martin-strecker-sonarsource marked this pull request as ready for review June 11, 2024 16:00
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban Jun 11, 2024
pavel-mikula-sonarsource
pavel-mikula-sonarsource requested changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are bit more tricky

analyzers/src/SonarAnalyzer.CSharp/Rules/CollectionsShouldImplementGenericInterface.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/DoNotDecreaseMemberVisibility.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/DoNotHideBaseClassMethods.cs Outdated Show resolved Hide resolved
@github-actions github-actions bot moved this from Review in progress to In progress in Best Kanban Jun 12, 2024
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban Jun 13, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 13, 2024

Quality Gate Passed Quality Gate passed for 'Sonar .NET Java Plugin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 13, 2024

Quality Gate Passed Quality Gate passed for 'SonarAnalyzer for .NET'

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

pavel-mikula-sonarsource
pavel-mikula-sonarsource approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavel-mikula-sonarsource pavel-mikula-sonarsource merged commit 6037c1a into master Jun 14, 2024
28 checks passed
Best Kanban automation moved this from Review in progress to Validate Peach Jun 14, 2024
@pavel-mikula-sonarsource pavel-mikula-sonarsource deleted the Martin/ReportIssue_Remaining branch June 14, 2024 14:08
@martin-strecker-sonarsource martin-strecker-sonarsource moved this from Validate Peach to Done in Best Kanban Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavel-mikula-sonarsource pavel-mikula-sonarsource pavel-mikula-sonarsource approved these changes

Assignees

@martin-strecker-sonarsource martin-strecker-sonarsource

Labels
None yet
Projects
Best Kanban
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@martin-strecker-sonarsource @pavel-mikula-sonarsource