SONARJAVA-1369 Fix out of bounds when refering previous parameter

SonarSource · Nov 23, 2015 · 2659b9d · 2659b9d
1 parent 90a7b9f
commit 2659b9d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/java-checks/src/main/java/org/sonar/java/checks/PrintfCheck.java b/java-checks/src/main/java/org/sonar/java/checks/PrintfCheck.java
@@ -167,7 +167,10 @@ private void verifyParameters(MethodInvocationTree mit, List<ExpressionTree> arg
           return;
         }
         param = param.substring(param.indexOf("$") + 1);
-      } else if (!param.startsWith("<")) {
+      } else if (param.startsWith("<")) {
+        //refers to previous argument
+        argIndex = Math.max(0, argIndex - 1);
+      }else {
         index++;
       }
       ExpressionTree argExpressionTree = args.get(argIndex);

diff --git a/java-checks/src/test/files/checks/PrintfCheck.java b/java-checks/src/test/files/checks/PrintfCheck.java
@@ -78,5 +78,6 @@ void foo(Calendar c){
 
     String.format("Dude's Birthday: %1$tm %<te,%<tY", c); // Compliant
     String.format("Dude's Birthday: %1$tm %1$te,%1$tY", c); // Compliant
+    String.format("log/protocol_%tY_%<tm_%<td_%<tH_%<tM_%<tS.zip", new java.util.Date());
   }
 }