SONARJAVA-4988: Use SonarLintCache component and make it accessible to custom rules via the caching APIs #4792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-haubner-sonarsource
force-pushed
the
SONARJAVA-4988
branch
from
0bbf25e
to
3641961
Compare
DBD custom rules need this information to turn off saving IR to the filesystem in a SonarLint context
anton-haubner-sonarsource
force-pushed
the
SONARJAVA-4988
branch
from
3641961
to
686e380
Compare
anton-haubner-sonarsource
force-pushed
the
SONARJAVA-4988
branch
8 times, most recently
from
0a52aa2
to
6da8f93
Compare
Comment on lines
+382
to
+383
| issue.setPrimaryLocation((InputFile) fileOrProject, analyzerMessage.getMessage(), textSpan.startLine, textSpan.startCharacter, | ||
| textSpan.endLine, textSpan.endCharacter); |
There was a problem hiding this comment.
Nothing changed here, this is just the auto formatting.
Comment on lines
+555
to
+556
| "Cannot determine whether the context allows skipping unchanged files: canSkipUnchangedFiles not part of sonar-plugin-api. " + | ||
| "Not skipping. {}", |
There was a problem hiding this comment.
Again, this is just a formatting change.
anton-haubner-sonarsource
force-pushed
the
SONARJAVA-4988
branch
from
6da8f93
to
5c00fc8
Compare
Comment on lines
+119
to
+126
| private static final String LOG_MESSAGE_FILES_CAN_BE_SKIPPED = | ||
| "The Java analyzer is running in a context where unchanged files can be skipped. " + | ||
| "Full analysis is performed for changed files, optimized analysis for unchanged files."; | ||
| private static final String LOG_MESSAGE_FILES_CANNOT_BE_SKIPPED = | ||
| "The Java analyzer cannot skip unchanged files in this context. A full analysis is performed for all files."; | ||
| private static final String LOG_MESSAGE_CANNOT_DETERMINE_IF_FILES_CAN_BE_SKIPPED = | ||
| "Cannot determine whether the context allows skipping unchanged files: " + | ||
| "canSkipUnchangedFiles not part of sonar-plugin-api. Not skipping. {}"; |
There was a problem hiding this comment.
These are again just formatting changes.
anton-haubner-sonarsource
force-pushed
the
SONARJAVA-4988
branch
from
5c00fc8
to
9dc281f
Compare
alban-auzeill
approved these changes
Jun 3, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines: