Fix quality flaw: use immutable List instead of mutable List (#401)

SonarSource · Dec 13, 2023 · 5be4aaf · 5be4aaf
1 parent 7f85757
commit 5be4aaf
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/sonar-kotlin-checks/src/main/java/org/sonarsource/kotlin/checks/CipherModeOperationCheck.kt b/sonar-kotlin-checks/src/main/java/org/sonarsource/kotlin/checks/CipherModeOperationCheck.kt
@@ -78,7 +78,7 @@ class CipherModeOperationCheck : CallAbstractCheck() {
     }
 }
 
-private fun generateSecondaryLocations(secondaries: MutableList<PsiElement>, kotlinFileContext: KotlinFileContext) =
+private fun generateSecondaryLocations(secondaries: List<PsiElement>, kotlinFileContext: KotlinFileContext) =
     secondaries.mapIndexed { i, secondary ->
         if (i < secondaries.size - 1) {
             SecondaryLocation(kotlinFileContext.textRange(secondary), "Initialization vector is configured here.")

diff --git a/...-checks/src/main/java/org/sonarsource/kotlin/checks/RedundantMethodsInDataClassesCheck.kt b/...-checks/src/main/java/org/sonarsource/kotlin/checks/RedundantMethodsInDataClassesCheck.kt
@@ -206,7 +206,7 @@ private fun findParameter(
 private fun checkDotExpression(
     expression: KtExpression?,
     klassParameter: KtParameter,
-    methodParameters: MutableList<KtParameter>,
+    methodParameters: List<KtParameter>,
 ): Boolean =
     if (expression is KtDotQualifiedExpression) {
         ((expression.receiverExpression as KtNameReferenceExpression).getReferencedName() == methodParameters[0].name