[WIP] Replace "kotlin-compiler-embeddable" by "kotlin-compiler" #424
Conversation
| import com.google.common.collect.ImmutableList // Noncompliant | ||
| import com.google.common.collect.ImmutableList.copyOf // Noncompliant |
There was a problem hiding this comment.
This is the only issue affected, but those 2 are TP. But only on Linux/MacOS (the Windows build is failing because of this change). I don't know what to do since this is a partial semantic test. Maybe we can accept this or drop these lines.
leveretka
force-pushed
the
margo/migrate-kotlin-compiler
branch
from
f47b6a3
to
5883e12
Compare
leveretka
force-pushed
the
margo/migrate-kotlin-compiler
branch
from
5883e12
to
e860acf
Compare
|
| @@ -96,7 +96,7 @@ private static void parseFiles(List<File> reports, UnitTestIndex index) { | |||
| try { | |||
| parser.parse(report); | |||
| } catch (XMLStreamException e) { | |||
| throw new ParseException("Fail to parse the Surefire report: " + report, null, e); | |||
| throw new ParseException(e); | |||
There was a problem hiding this comment.
I see that the constructor of the class does not take a message AND a cause. Can we maybe log it a least so that we do not completely lose the information?
| throw new ParseException(e); | |
| LOGGER.warn("Fail to parse the Surefire report: " + report); | |
| throw new ParseException(e); |
| @@ -15,8 +15,12 @@ dependencies { | |||
| implementation(libs.kotlin.compiler.embeddable) | |||
| implementation(utilLibs.bundles.ktlint) | |||
|
|
|||
| implementation(project(":sonar-kotlin-plugin")) | |||
| implementation(project(":sonar-kotlin-api")) | |||
| implementation(project(":sonar-kotlin-plugin")) { | |||
There was a problem hiding this comment.
Can we leave a comment here explaining why we place this restriction on inheriting the transitive dependencies of the project? WIthout a ticket, it will be difficult in the future to understand why me made this change
There was a problem hiding this comment.
I am guessing this is the class that was copied. Let's add a comment with the origin of this file
I only migrated our plugin, however the module "utils-kotlin" still needs "kotlin-compiler-embeddable", so had to copy few classes to avoid dependency clashes.