SONARPY-1764 Enrich FunctionType #1764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaume-dequenne-sonarsource
force-pushed
the
SONARPY-1764
branch
2 times, most recently
from
bbd176e
to
e2db425
Compare
guillaume-dequenne-sonarsource
force-pushed
the
SONARPY-1764
branch
from
e2db425
to
8c84328
Compare
guillaume-dequenne-sonarsource
requested a review
from maksim-grebeniuk-sonarsource
guillaume-dequenne-sonarsource
force-pushed
the
SONARPY-1764
branch
from
19ee430
to
6cee6ad
Compare
guillaume-dequenne-sonarsource
force-pushed
the
SONARPY-1764
branch
from
145821a
to
06a6276
Compare
maksim-grebeniuk-sonarsource
approved these changes
Apr 18, 2024
|
guillaume-dequenne-sonarsource
merged commit 2009d3c
into
rnd/type-inference-engine-specification
9 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bulk of this change transfers the logic with
FunctionSymbolto the newFunctionType.Some things are not currently handled, namely:
While I believe the main logic of
FunctionSymbolis still valid in the new model, these three points specifically deserve some more thought. Dedicated tickets have been created to handle them (SONARPY-1772, SONARPY-1773 and SONARPY-1776