Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONARPY-1794 Avoid inferring types for global variables #1771

Conversation

guillaume-dequenne-sonarsource
Copy link
Contributor

This PR is currently targeting SONARPY-1789 as it's built upon its changes.
When SONARPY-1789 is reviewed and merged into our feature branch, this PR should target the feature branch as well and be rebased.

@guillaume-dequenne-sonarsource guillaume-dequenne-sonarsource marked this pull request as ready for review April 25, 2024 08:39
@guillaume-dequenne-sonarsource guillaume-dequenne-sonarsource changed the title SONARPY-1794 SONARPY-1794 Avoiding inferring types for global variables Apr 25, 2024
@guillaume-dequenne-sonarsource guillaume-dequenne-sonarsource changed the title SONARPY-1794 Avoiding inferring types for global variables SONARPY-1794 Avoid inferring types for global variables Apr 25, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from SONARPY-1789 to rnd/type-inference-engine-specification April 25, 2024 12:33
Copy link

@guillaume-dequenne-sonarsource guillaume-dequenne-sonarsource merged commit 6fa1260 into rnd/type-inference-engine-specification Apr 25, 2024
0 of 8 checks passed
guillaume-dequenne-sonarsource added a commit that referenced this pull request May 1, 2024
* SONARPY-1794 Avoid inferring types for global variables

* Update ruling expectations
guillaume-dequenne-sonarsource added a commit that referenced this pull request May 1, 2024
* SONARPY-1794 Avoid inferring types for global variables

* Update ruling expectations
guillaume-dequenne-sonarsource added a commit that referenced this pull request May 15, 2024
* SONARPY-1794 Avoid inferring types for global variables

* Update ruling expectations
guillaume-dequenne-sonarsource added a commit that referenced this pull request May 21, 2024
* SONARPY-1794 Avoid inferring types for global variables

* Update ruling expectations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants