-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SONARPY-1794 Avoid inferring types for global variables #1771
Merged
guillaume-dequenne-sonarsource
merged 2 commits into
rnd/type-inference-engine-specification
from
SONARPY-1794
Apr 25, 2024
Merged
SONARPY-1794 Avoid inferring types for global variables #1771
guillaume-dequenne-sonarsource
merged 2 commits into
rnd/type-inference-engine-specification
from
SONARPY-1794
Apr 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d1c8043
to
2f038f9
Compare
2f038f9
to
e77aa8e
Compare
e77aa8e
to
3e6ca06
Compare
maksim-grebeniuk-sonarsource
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Base automatically changed from
SONARPY-1789
to
rnd/type-inference-engine-specification
April 25, 2024 12:33
|
3e6ca06
to
7fcfc51
Compare
6fa1260
into
rnd/type-inference-engine-specification
0 of 8 checks passed
guillaume-dequenne-sonarsource
added a commit
that referenced
this pull request
May 1, 2024
* SONARPY-1794 Avoid inferring types for global variables * Update ruling expectations
guillaume-dequenne-sonarsource
added a commit
that referenced
this pull request
May 1, 2024
* SONARPY-1794 Avoid inferring types for global variables * Update ruling expectations
guillaume-dequenne-sonarsource
added a commit
that referenced
this pull request
May 15, 2024
* SONARPY-1794 Avoid inferring types for global variables * Update ruling expectations
guillaume-dequenne-sonarsource
added a commit
that referenced
this pull request
May 21, 2024
* SONARPY-1794 Avoid inferring types for global variables * Update ruling expectations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is currently targeting SONARPY-1789 as it's built upon its changes.
When SONARPY-1789 is reviewed and merged into our feature branch, this PR should target the feature branch as well and be rebased.