SONARPY-1796 Infer types for set, dict and tuple literals #1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaume-dequenne-sonarsource
force-pushed
the
SONARPY-1794
branch
from
3e6ca06
to
7fcfc51
Compare
Base automatically changed from
SONARPY-1794
to
rnd/type-inference-engine-specification
April 25, 2024 12:47
guillaume-dequenne-sonarsource
force-pushed
the
SONARPY-1796
branch
5 times, most recently
from
a22dca6
to
5ee5e31
Compare
guillaume-dequenne-sonarsource
force-pushed
the
SONARPY-1796
branch
2 times, most recently
from
a2d55d2
to
6ac36b5
Compare
guillaume-dequenne-sonarsource
force-pushed
the
SONARPY-1796
branch
from
6ac36b5
to
4cf3e3b
Compare
guillaume-dequenne-sonarsource
requested a review
from maksim-grebeniuk-sonarsource
| } | ||
| ModuleType builtins = this.projectLevelTypeTable.getModule(BUILTINS); | ||
| PythonType tupleType = builtins.resolveMember("tuple").orElse(PythonType.UNKNOWN); | ||
| ((TupleImpl) tuple).typeV2(new ObjectType(tupleType, attributes, List.of())); |
There was a problem hiding this comment.
using List.of() could be dangerous since it is immutable. I'd prefer to use array lists instead
guillaume-dequenne-sonarsource
requested a review
from maksim-grebeniuk-sonarsource
maksim-grebeniuk-sonarsource
approved these changes
Apr 26, 2024
|
guillaume-dequenne-sonarsource
merged commit bfea989
into
rnd/type-inference-engine-specification
10 checks passed
guillaume-dequenne-sonarsource
added a commit
that referenced
this pull request
May 1, 2024
guillaume-dequenne-sonarsource
added a commit
that referenced
this pull request
May 1, 2024
guillaume-dequenne-sonarsource
added a commit
that referenced
this pull request
May 15, 2024
guillaume-dequenne-sonarsource
added a commit
that referenced
this pull request
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tuple content type is inferred immediately if (and unique) available as tuple are immutables.
This should be seen as a baby step/low-hanging fruit. I'd expect a dedicated effort to tackle any more complex case.
Also, this PR does not deal with display name/representation of those generic types.
Not 100% related to the ticket, but I also took the opportunity to add some missing test for some already covered literal types (str, numeric literals and None).