SONARPY-1800 NonCallableCallCheck migration: Use the display name of the new type model #1777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaume-dequenne-sonarsource
force-pushed
the
SONARPY-1800
branch
8 times, most recently
from
d8d65e3
to
7db3a7e
Compare
guillaume-dequenne-sonarsource
requested a review
from maksim-grebeniuk-sonarsource
…the new type model
guillaume-dequenne-sonarsource
force-pushed
the
SONARPY-1800
branch
from
7db3a7e
to
c077762
Compare
|
| if (name != null) { | ||
| return String.format("Fix this call; \"%s\"%s is not callable.", name, addTypeName(calleeType)); | ||
| return String.format("Fix this call; \"%s\"%s is not callable.", name, addTypeName(typeV2)); |
There was a problem hiding this comment.
In currently used Java version String.format could be simplified by the String.formatted method:
"Fix this call; \"%s\"%s is not callable.".formatted(name, addTypeName(typeV2))
maksim-grebeniuk-sonarsource
approved these changes
Apr 29, 2024
guillaume-dequenne-sonarsource
merged commit de9a80f
into
rnd/type-inference-engine-specification
0 of 8 checks passed
guillaume-dequenne-sonarsource
added a commit
that referenced
this pull request
May 1, 2024
…the new type model (#1777)
guillaume-dequenne-sonarsource
added a commit
that referenced
this pull request
May 1, 2024
…the new type model (#1777)
guillaume-dequenne-sonarsource
added a commit
that referenced
this pull request
May 15, 2024
…the new type model (#1777)
guillaume-dequenne-sonarsource
added a commit
that referenced
this pull request
May 21, 2024
…the new type model (#1777)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.