SONARPY-1803 Store type definition location in the new type model #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaume-dequenne-sonarsource
force-pushed
the
SONARPY-1803
branch
from
d72e818
to
7878518
Compare
guillaume-dequenne-sonarsource
force-pushed
the
SONARPY-1803
branch
2 times, most recently
from
a890124
to
235aa23
Compare
guillaume-dequenne-sonarsource
force-pushed
the
SONARPY-1803
branch
from
235aa23
to
bf69060
Compare
guillaume-dequenne-sonarsource
requested a review
from maksim-grebeniuk-sonarsource
maksim-grebeniuk-sonarsource
approved these changes
Apr 29, 2024
|
guillaume-dequenne-sonarsource
merged commit ee6d13f
into
rnd/type-inference-engine-specification
9 of 10 checks passed
guillaume-dequenne-sonarsource
added a commit
that referenced
this pull request
May 1, 2024
guillaume-dequenne-sonarsource
added a commit
that referenced
this pull request
May 1, 2024
guillaume-dequenne-sonarsource
added a commit
that referenced
this pull request
May 15, 2024
guillaume-dequenne-sonarsource
added a commit
that referenced
this pull request
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be honest I'm not entirely convinced of the proposed solution and I think you made good points in our discussion, so my goal here is to make sure we have a first baby step that can be used in the
NonCallableCalledCheckand can be revisited later.One thing to note is that both
ObjectTypeandClassTypewill point to the definition of the class. To be consistent with thedisplayNameimplementation,ClassType#definitionLocationshould probably refer to the definition oftype, however, I didn't think that makes sense (no such definition could be found anyway) so they both return the location of the class definition instead.