Support Android Gradle 3 #33
Conversation
| @@ -41,14 +41,17 @@ repositories { | |||
| mavenLocal() | |||
| mavenCentral() | |||
| maven { | |||
| url "https://maven.google.com" | |||
There was a problem hiding this comment.
can be replace by google()
https://developer.android.com/studio/build/dependencies.html#google-maven
There was a problem hiding this comment.
I know, it depends which version of gradle you use. So this can be changed in a future PR.
Gradle 4.0 doesn't know about google() but would still be able to build everything...
|
Please merge so we can pull snapshot builds if this doesn't break backwards compatibility w/ AGP 2.3.3 |
| @@ -211,7 +211,7 @@ private static void populateSonarQubeProps(Map<String, Object> properties, List< | |||
| // I don't know what is best: ApkVariant::getCompileLibraries() or BaseVariant::getJavaCompile()::getClasspath() | |||
|
If you really need this now. You can always use my branch and build it yourself or use jitpack |
|
Squashed and fixed integration tests in #34. Thanks for your contribution! |
|
@Shusshu it looks like deleting your branch removed the archive on jitpack. Would you mind keeping that branch around until the official update comes out? |
|
I have deployed a RC1: https://plugins.gradle.org/plugin/org.sonarqube/2.6-rc1 |
|
2.6-rc1 seems to work ok for me, thanks 👍 |
|
Thanks for the feedback, 2.6 is already out, but better late than never ;) |
https://jira.sonarsource.com/browse/SONARGRADL-41