Internal PR for #124 #132
Merged
Internal PR for #124 #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouter-admiraal-sonarsource
force-pushed
the
feature/wad/pr-124
branch
from
6ac67ad
to
d8a9f00
Compare
henryju
approved these changes
Oct 29, 2019
wouter-admiraal-sonarsource
force-pushed
the
feature/wad/pr-124
branch
3 times, most recently
from
e6a9cab
to
b308c38
Compare
|
Are we now good to go with this PR? |
Co-Authored-By: Tim Jacomb <t.jacomb@kainos.com>
wouter-admiraal-sonarsource
force-pushed
the
feature/wad/pr-124
branch
from
b308c38
to
fe5eac3
Compare
We had some issues with the QA. It should be fixed now. Waiting for it to be green. |
|
@Smasherr Done! Thank you for your patience |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #124